Skip to content

Update changelog since v5.1.0 #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2021
Merged

Update changelog since v5.1.0 #104

merged 3 commits into from
Jan 24, 2021

Conversation

thomashoneyman
Copy link
Contributor

Description of the change

This PR updates the CHANGELOG in preparation for the upcoming release of this library.

Related: purescript/purescript#3985


New features:

Bugfixes:

Other improvements:
- Changed default branch to `main` from `master`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing #98?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added! Thanks.

@@ -5,181 +5,204 @@ Notable changes to this project are documented in this file. The format is based
## [Unreleased]

Breaking changes (😱!!!):
- Non-empty combinators return `NonEmptyList` ([#102](https://github.com/purescript-contrib/purescript-parsing/pull/102))
- Non-empty combinators now return `NonEmptyList` (#102)
- Added support for PureScript 0.14 and dropped support for all previous versions (#103)

New features:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing #87?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added! Good catch.

CHANGELOG.md Outdated
@@ -5,181 +5,204 @@ Notable changes to this project are documented in this file. The format is based
## [Unreleased]

Breaking changes (😱!!!):
- Non-empty combinators return `NonEmptyList` ([#102](https://github.com/purescript-contrib/purescript-parsing/pull/102))
- Non-empty combinators now return `NonEmptyList` (#102)
- Added support for PureScript 0.14 and dropped support for all previous versions (#103)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#101 did this. #103 might be a separate thing entirely.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems #93 is also missing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing #97? Not sure if it's breaking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches! I've added #101 and #93. #97 is included in the v5.1.0 release, so I've left it out. I've updated #103; I remember doing it as part of 0.14 changes but they're not specific to the 0.14 release, just a breaking change in a dependency.

Copy link
Contributor

@JordanMartinez JordanMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a few PRs missing in this one.

@JordanMartinez JordanMartinez merged commit ef2d38f into main Jan 24, 2021
@JordanMartinez JordanMartinez deleted the changelog-0.14 branch January 24, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants