Skip to content

Bugfix Combinators.Array.many #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 8, 2025
Merged

Bugfix Combinators.Array.many #240

merged 4 commits into from
Mar 8, 2025

Conversation

jamesdbrock
Copy link
Member

@jamesdbrock jamesdbrock commented Mar 8, 2025 •
edited
Loading

Resolve #234

Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

@jamesdbrock jamesdbrock changed the title Arraycomb Bugfix Combinators.Array.many Mar 8, 2025
@jamesdbrock jamesdbrock marked this pull request as ready for review March 8, 2025 05:35
@jamesdbrock
Combinators.Array.many tests
e56b5ec
@jamesdbrock
Bugfix: Delete the try in Combinators.Array.many
5672106 
According to the semantics of “consume”:

If the phrase parser fails without consuming then that is the end of the
many.
If the phrase parser fails after consuming then the whole parse has
failed.
@jamesdbrock jamesdbrock merged commit 64c044e into main Mar 8, 2025
1 check passed
@jamesdbrock jamesdbrock deleted the arraycomb branch March 8, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Array combinators don't propagate fail "with consumption"
1 participant
@jamesdbrock