Strengthen "foreign import" highlight #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit a valid code like
foreign import
foo
wasn't getting correctly highlighted. This fixes it.
While doing so, we also remove all the ccall/stdcall/etc stuff, which
is a legacy from haskell-mode and doesn't exist in purescript.
"foreign export" isn't a thing in PureScript. It's a legacy from haskell-mode, remove it.
Hi-Angel
force-pushed
the
fix-foreign-import-highlight
branch
from
0e63abd to
98648c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where
foreign importwasn't getting highlighted if it's the only text on the line, adds a bunch of tests for this syntax, and gets rid offoreign export, which isn't a thing in PureScript, as can be seen here.