PureScript 0.15 updates #24
Conversation
|
Awesome, thanks @ptrfrncsmrph! I'll fix the travis/github ci stuff real quick before we get this in to make sure CI is passing |
|
Actually since this adds spago (thanks for that!) maybe you want to do that as part of this PR. Here's an example, just remove the examples building at the bottom - https://github.com/lumihq/purescript-react-basic-classic/blob/main/.github/workflows/ci.yml |
packages.dhall
Outdated
| @@ -0,0 +1,138 @@ | |||
| {- | |||
There was a problem hiding this comment.
Would you mind removing this and the comment from the spago.dhall also? They are a lot of noise that don't add that much value IMO
There was a problem hiding this comment.
Oops, sorry was still a bit of WIP so I was keeping as a draft for now. I didn't know if there was interest in getting this up to date with [email protected] but I noticed it's (I think) the only dep of lumi-components that hasn't been updated yet. I see that there is 😄 I'll address feedback and probably make some more changes today.
There was a problem hiding this comment.
Would be awesome to keep it up to date 😄 its been on the TODO list, just haven't gotten to it yet
|
Hmm, now I'm seeing a failure with but I don't know where Edit: Oh, I guess it's running the older version of the CI workflow? Will try changing this from Draft to see if that changes how it runs. |
|
Ah, I see now, it was Travis CI that's configured with old Node version {
"language": "node_js",
"os": [
"linux"
],
"dist": "trusty",
"sudo": true,
"node_js": [
"10"
],
"install": [
"npm install"
],
"script": [
"npx bower install",
"npm -s test"
]
}I'm guessing Travis would have to be disabled by maintainer, and then the GitHub workflow could be approved and run? (Sorry for noise of extraneous commits!) |
No worries! If you want you can remove Travis in this PR (delete the .travis.yml file) or I can push that to main |
| You can build this example from the root of the `purescript-react-dnd-basic` project: | ||
|
|
||
| ```sh | ||
| npm install | ||
| make all | ||
| npm run example:basic | ||
| ``` | ||
|
|
||
| This will compile the PureScript source files, bundle them, and use Browserify to combine PureScript and NPM sources into a single bundle. | ||
| This will compile the PureScript source files, bundle them, and combine PureScript and NPM sources into a single bundle. |
There was a problem hiding this comment.
Changed this to be a bit more like the Halogen examples: https://github.com/purescript-halogen/purescript-halogen/tree/master/examples/basic (removed the Makefile and package.json from this directory in favor of running spago from root directory and adding NPM deps to top-level devDependencies).
It would be nice to have some tests 😄 and to be able to use any examples/ modules in the tests. Started looking into that, but seemed too much for this PR, just manually tested that the basic example still works.
| let config = ./../../spago.dhall | ||
|
|
||
| in config | ||
| // { sources = config.sources # [ "examples/basic/**/*.purs" ] | ||
| , dependencies = | ||
| config.dependencies | ||
| # [ "arrays" | ||
| , "exceptions" | ||
| , "foldable-traversable" | ||
| , "integers" | ||
| , "react-basic" | ||
| , "react-basic-dom" | ||
| , "web-html" | ||
| ] | ||
| } |
There was a problem hiding this comment.
This formatting looks a bit strange, but this is how dhall format likes things 🤷
| main :: Effect Unit | ||
| main = do | ||
| maybeContainer <- window | ||
| >>= document | ||
| >>= toNonElementParentNode | ||
| >>> getElementById "container" | ||
| case maybeContainer of | ||
| Nothing -> throw "Container element not found." | ||
| Just container -> do | ||
| todoExample <- mkTodoExample | ||
| render (todoExample unit) container |
There was a problem hiding this comment.
This used to be in a separate index.js, and there was a Browserify command in the Makefile that would bundle it with the purs output (after writing module.exports = PS.Basic;). It seemed simpler to just use spago bundle-app with a single PS module.
|
Thanks for this! |
No description provided.