Add fixtures for API responses #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomashoneyman
commented
Mar 19, 2021
| @@ -6,7 +6,9 @@ | |||
| }, | |||
| "scripts": { | |||
| "clean": "rimraf output", | |||
| "build": "spago bundle-app --path $npm_package_config_configpath --purs-args '--censor-lib --strict' --to public/js/index.js" | |||
| "test": "spago test --path $npm_package_config_configpath", | |||
| "build": "spago build --path $npm_package_config_configpath", | |||
There was a problem hiding this comment.
Could we switch this environment variable to something a little shorter? Perhaps TRY_CONFIG?
There was a problem hiding this comment.
The reason we have the npm_package_config_ prefix is so that it can pick up the values from the config key in package.json by default if they haven't been explicitly overridden (e.g. like we do in CI:
Line 16 in 52c81fc
npm_package_config_ prefix for this to work. If there's another way to make npm run build Just Work in development and for the production config to be used in CI I'm happy to consider that.
hdgarrood
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PureScript 0.14 release helped drive the point home, for me, that core libraries and infrastructure ought to use core libraries (or contrib, or node, etc.) wherever possible.
As part of the updates originally outlined in #199 I thought we could switch to use
argonautrather thanforeign-genericfor the API in Try PureScript. We already depend onargonautand are receiving itsJsontype via Affjax, so it feels like a more natural fit thanforeign-genericin addition to being a contrib library.This PR takes a first step by adding API response fixtures and tests for the existing
foreign-genericimplementation. This helps ensure that switching to a new library will still decode correctly without having to test manually.