Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow upgraded #64

Merged
merged 1 commit into from
Feb 13, 2025
Merged

workflow upgraded #64

merged 1 commit into from
Feb 13, 2025

Conversation

rohitmalhotra1420
Copy link
Collaborator

No description provided.

@rohitmalhotra1420 rohitmalhotra1420 self-assigned this Feb 13, 2025
@rohitmalhotra1420 rohitmalhotra1420 merged commit bb5ba22 into main Feb 13, 2025
1 check passed
Copy link

  1. In the "permissions" section, replace 'id-token' with 'id-token: write' for consistency.
  2. In the "concurrency" section, it's usually better to have a balance between canceling and allowing some concurrency, so please review if 'cancel-in-progress: false' is the desired behavior.
  3. In the "jobs.build.steps" section, the $GITHUB_OUTPUT variable is being used without declaration. You should define this variable or use a different approach to store the package manager configuration data.
  4. In the "jobs.build.steps.Setup Pages" section, the comment referencing "basePath" configuration seems to be wrong. It should be referring to "base path" instead.
  5. In the "jobs.build.steps.Upload artifact" section, the path should be './out' instead of just 'out'.
  6. In the "jobs.deploy.steps" section, the 'url' variable referenced as '${{ steps.deployment.outputs.page_url }}' is not defined. Ensure it is correctly defined in a previous step.

Code Review Summary: There are some issues that need to be addressed. Please make the necessary corrections based on the suggestions provided.

Please let me know if you need further assistance or when you have made the corrections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant