Responsive Chat + Reactions #1531

HarshRajat · 2024-05-15T17:19:34Z

Fixes:

Chat responsiveness SDK component container div
Enables chat users to go back to Chats tab once they accept a chat request
Adds a TODO comment on possible culprits for timeout errors happening on localhost
Bumps the package to alpha uiweb for supporting reactions

vercel · 2024-05-15T17:19:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
push-dapp	❌ Failed (Inspect)			May 24, 2024 9:00am

github-actions · 2024-05-15T17:20:11Z

In the provided files:

In the index.html file:
- The comments inside  tags are not properly formatted. They should be enclosed within <p> or other HTML tags to appear correctly in the browser.
- There is a missing closing <html> tag at the end of the file.
In the package.json file:
- The dependencies section seems to include ellipses (...) which should be replaced with actual dependencies for the sake of completeness.
- There is a missing closing curly brace } at the end of the dependencies section before the "devDependencies" section.
- The "devDependencies" section is not shown completely, hence it's unclear if there are any issues or not.
- The indentation in the script commands can be made consistent for better readability.
In the public/robots.txt file:
- The robots.txt file appears to be correctly formatted with a user-agent and sitemap directives.
In the public/sitemap.txt file:
- The sitemap.txt file looks well-structured with a list of URLs for different sections of the website.
The src/sections/chat/ChatSection.tsx, yarn.lock files were not provided, so they couldn't be reviewed.

Overall, the HTML and configuration files have some minor issues that need attention, but there are no critical errors. If the missing files are provided for review, a more thorough evaluation can be done.

…l/push-dapp into chat-responsive-fix

github-actions · 2024-05-15T17:23:15Z

It seems you provided multiple files for the code review but only the content of index.html file is visible. Could you please also provide the content of other files mentioned (package.json, public/robots.txt, public/sitemap.txt, src/sections/chat/ChatSection.tsx, yarn.lock) so that a thorough review can be conducted? Thank you.

…to become responsive

rohitmalhotra1420

@HarshRajat

Could you let me know what does this pr exactly fix.
Fix the alpha deployment file changes.
Resolve the merge conflicts on this one

index.html

github-actions · 2024-05-21T20:55:11Z

In index.html:

Missing closing angle bracket for the meta tag: <meta name="theme-color" content="#ffffff">. It should be <meta name="theme-color" content="#ffffff">.
Missing opening tag for <link> with rel="manifest" and href="/site.webmanifest".

In package.json:

The "dependencies" object is missing a closing curly brace at the end.

In public/robots.txt:
All looks good.

In public/sitemap.txt:
All looks good.

In src/components/InitState.tsx:
All looks good.

In src/components/ViewDelegateeItem.jsx:
All looks good.

In src/hooks/useResolveWeb3Name.ts:
All looks good.

In src/modules/chat/ChatModule.tsx:

The formatting of the component function seems to be incorrect. Some lines are not wrapped properly.

In src/modules/inbox/InboxModule.tsx:
All looks good.

In src/sections/chat/ChatSection.tsx:
All looks good.

In src/singletons/ChannelsDataStore.js:
All looks good.

In yarn.lock:
All looks good.

github-actions · 2024-05-21T20:58:24Z

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-27 16:18 UTC

src/components/ViewDelegateeItem.jsx

index.html

rohitmalhotra1420 · 2024-05-22T10:35:13Z

package.json

@@ -34,9 +34,9 @@
    "@metamask/eth-sig-util": "^4.0.0",
    "@mui/icons-material": "^5.8.4",
    "@mui/material": "^5.5.0",
-    "@pushprotocol/restapi": "1.7.18",
+    "@pushprotocol/restapi": "1.7.19",


https://push-protocol.github.io/push-dapp/pr-preview/pr-1531/channels

The Developer section and the channels page keeps on loading on the preview URL. It is working on other PR previews.

I see a localhost error in the console. My guess is this this is related to the restapi package. Right?

Weird, I don't think restapi should change the behavior, reverting robots, sitemap and index to prod config to see if that somehow fixes this.

src/singletons/ChannelsDataStore.js

…ateeItem

github-actions · 2024-05-22T16:24:25Z

All looks good.

github-actions · 2024-05-24T07:33:53Z

All looks good.

github-actions · 2024-05-24T08:47:25Z

There are a few issues in the provided code snippets:

In the .github/workflows/preview.yml file:

The yarn install and yarn build:pr:preview commands in the Install and Build job are not properly formatted. They should be placed in separate run steps.

In the .github/workflows/preview.yml file:

In the Deploy preview job, there is a redundant step that uses rossjrw/[email protected]. It seems to be a duplicate step and should be removed.

In the .github/workflows/preview.yml file:

There is a missing - name: Delete Preview before the if condition in the job step. It looks like there was an attempt to add a new step but it is incomplete and the existing step goes directly to the conditions.

In the package.json file:

There is an extra , at the end of the dependencies list before the ellipsis which is not needed.

In the src/components/InitState.tsx file:

There is a typo in the function call pushUser.channel.info() should be checked for any possible errors or misspellings.

In the src/components/ViewDelegateeItem.jsx file:

The import statement for LoaderSpinner imports it from a wrong path. It should be corrected to the correct path where LoaderSpinner is located.

In the src/components/ViewDelegateeItem.jsx file:

The import statement for Blockies is misspelled. It should be corrected to import Blockies from 'components/reusables/BlockiesIdenticon';.

After addressing these issues, the code should be more correct. If you need further assistance or clarification, feel free to ask.

github-actions · 2024-05-24T08:50:57Z

All looks good.

github-actions · 2024-05-24T08:56:20Z

All looks good.

rohitmalhotra1420 · 2024-05-27T16:18:09Z

Closing this PR as we have a created a fresh PR by checking out to a new branch chat-reactions from this branch: #1581

responsive-fix-wrt-sdk

cb023b6

HarshRajat added 2 commits May 15, 2024 21:21

removing unnecessary files

1e3e771

Merge branch 'chat-responsive-fix' of https://github.com/push-protoco…

7dd0934

…l/push-dapp into chat-responsive-fix

vercel bot had a problem deploying to Preview May 15, 2024 17:23 Failure

Identified errors origin for constant infura timeout, tweak for chat …

f492cbd

…to become responsive

vercel bot had a problem deploying to Preview May 21, 2024 13:01 Failure

rohitmalhotra1420 requested changes May 21, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

HarshRajat changed the title ~~responsive-fix-wrt-sdk~~ Responsive Chat + Reactions May 21, 2024

HarshRajat added 3 commits May 22, 2024 00:37

package upgrade

8a434d6

added regenerated yarn.lock

e860a4d

added regenerated yarn.lock and merged ViewDelegateeItem.jsx

1508556

vercel bot had a problem deploying to Preview May 21, 2024 20:59 Failure

rohitmalhotra1420 requested changes May 22, 2024

View reviewed changes

rohitmalhotra1420 reviewed May 22, 2024

View reviewed changes

src/singletons/ChannelsDataStore.js Show resolved Hide resolved

Reverted index.html, sitemap and robots. Removed React from ViewDeleg…

494bdc7

…ateeItem

vercel bot had a problem deploying to Preview May 22, 2024 16:29 Failure

HarshRajat requested a review from rohitmalhotra1420 May 22, 2024 16:30

updated the uiweb version

964d7f7

vercel bot had a problem deploying to Preview May 24, 2024 07:38 Failure

rohitmalhotra1420 requested a review from mishramonalisha76 May 24, 2024 07:56

rohitmalhotra1420 assigned HarshRajat May 24, 2024

rohitmalhotra1420 added 2 commits May 24, 2024 14:16

added github action

009009e

fixed icon path

33bd67c

reverted restapi version

198a8a2

vercel bot had a problem deploying to Preview May 24, 2024 08:47 Failure

ficed preview.yml

b4c7576

vercel bot had a problem deploying to Preview May 24, 2024 08:50 Failure

lock file fixed

39ac410

vercel bot had a problem deploying to Preview May 24, 2024 09:00 Failure

rohitmalhotra1420 closed this May 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Responsive Chat + Reactions #1531

Responsive Chat + Reactions #1531

HarshRajat commented May 15, 2024 •

edited

Loading

vercel bot commented May 15, 2024 •

edited

Loading

github-actions bot commented May 15, 2024

github-actions bot commented May 15, 2024

rohitmalhotra1420 left a comment

github-actions bot commented May 21, 2024

github-actions bot commented May 21, 2024 •

edited

Loading

rohitmalhotra1420 May 22, 2024

HarshRajat May 22, 2024 •

edited

Loading

github-actions bot commented May 22, 2024

github-actions bot commented May 24, 2024

github-actions bot commented May 24, 2024

github-actions bot commented May 24, 2024

github-actions bot commented May 24, 2024

rohitmalhotra1420 commented May 27, 2024 •

edited

Loading

Responsive Chat + Reactions #1531

Responsive Chat + Reactions #1531

Conversation

HarshRajat commented May 15, 2024 • edited Loading

vercel bot commented May 15, 2024 • edited Loading

github-actions bot commented May 15, 2024

github-actions bot commented May 15, 2024

rohitmalhotra1420 left a comment

Choose a reason for hiding this comment

github-actions bot commented May 21, 2024

github-actions bot commented May 21, 2024 • edited Loading

rohitmalhotra1420 May 22, 2024

Choose a reason for hiding this comment

HarshRajat May 22, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented May 22, 2024

github-actions bot commented May 24, 2024

github-actions bot commented May 24, 2024

github-actions bot commented May 24, 2024

github-actions bot commented May 24, 2024

rohitmalhotra1420 commented May 27, 2024 • edited Loading

HarshRajat commented May 15, 2024 •

edited

Loading

vercel bot commented May 15, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading

HarshRajat May 22, 2024 •

edited

Loading

rohitmalhotra1420 commented May 27, 2024 •

edited

Loading