Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skeleton loader added to Unlock Profile #1567

Merged
merged 3 commits into from
May 31, 2024
Merged

Skeleton loader added to Unlock Profile #1567

merged 3 commits into from
May 31, 2024

Conversation

abhishek-01k
Copy link
Collaborator

@abhishek-01k abhishek-01k commented May 23, 2024 •
edited by rohitmalhotra1420
Loading

Pull Request Template

Ticket Number:

Ticket Number = #1535

Description

When the dapp was being reloaded in the /chat routes User sees unlock profile button. That needs to be changed in to skeleton loader.

Type of Change

  • Bug fix

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@abhishek-01k abhishek-01k self-assigned this May 23, 2024
@vercel Vercel
Copy link

vercel bot commented May 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
push-dapp ❌ Failed (Inspect) May 27, 2024 10:57am

@github-actions GitHub Actions
Copy link

All looks good.

@abhishek-01k abhishek-01k linked an issue May 23, 2024 that may be closed by this pull request
🐛 [BUG] - Seeing un lock profile section after reload #1535
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-31 07:57 UTC

@rohitmalhotra1420
Copy link
Collaborator

@abhishek-01k please add a skeleton loader for the remember me checkbox or remove it. Zee can give a better answer on this one.

@github-actions GitHub Actions
Copy link

All looks good.

rohitmalhotra1420
rohitmalhotra1420 requested changes May 27, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

All looks good.

mishramonalisha76
mishramonalisha76 approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@mishramonalisha76 mishramonalisha76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohitmalhotra1420 rohitmalhotra1420 merged commit 31735a0 into main May 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitmalhotra1420 rohitmalhotra1420 rohitmalhotra1420 approved these changes

@mishramonalisha76 mishramonalisha76 mishramonalisha76 approved these changes

Assignees

@abhishek-01k abhishek-01k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Seeing un lock profile section after reload
3 participants
@abhishek-01k @rohitmalhotra1420 @mishramonalisha76