Space id integration

[mishramonalisha76]

Pull Request Template

Ticket Number

• 1575

Description

• Problem/Feature: Enhanced the domain resolution process by using the space-id package. Now all domain supported by space-id can be resolved, including bnb , eth and unstoppable domains.

Type of Change

• Bug fix
• New feature
• Code refactor
• Documentation update
• Other (please describe):

Checklist

• Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
  • Quick PR label added
• Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
  • DO NOT Merge PR label added

Frontend Guidelines

• Followed frontend guidelines as per the Guidelines Notion Doc

Build & Testing

• No errors in the build terminal
• Engineer has tested the changes on their local environment
• Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

• Before: Explain the previous behavior

• After: What's changed now

Additional Context

Review & Approvals

• Self-review completed
• Code review by at least one other engineer
• Documentation updates if applicable

Notes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
push-dapp	❌ Failed (Inspect)			May 27, 2024 11:47am

[github-actions]

All looks good.

[github-actions]

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-30 07:11 UTC

[rohitmalhotra1420]

@mishramonalisha76 reopened this pull request.

[github-actions]

All looks good.

[rohitmalhotra1420]

@mishramonalisha76 the ticket description says resolved the domain name using space id package, but where is the space id package used?

[mishramonalisha76]

"@web3-name-sdk/core" this the space id package

[rohitmalhotra1420]

If we have this functionality inside the sdk library then why not use it from there and avoid installing the space id library here?

[mishramonalisha76]

not sure why its not getting installed from the sdk itself, even though its mentioned in dependencies in uiweb package

[rohitmalhotra1420]

@mishramonalisha76 this needs a second approval from @corlard3y .

[github-actions]

All looks good.

The merge-base changed after approval.

[github-actions]

The code provided has some issues:

1. In package.json, the script start:sdk:local is missing a reference to the start command at the end. It should be "start:sdk:local": "node dev-mode-link-local-sdk.mjs localsdk cleanup start".

2. In package.json, the script start:sdk:local:forcecleanup is missing a reference to the start command at the end. It should be "start:sdk:local:forcecleanup": "node dev-mode-link-local-sdk.mjs localsdk forcecleanup start".

3. In package.json, the script start:sdk:local:nocleanup is missing a reference to the start command at the end. It should be "start:sdk:local:nocleanup": "node dev-mode-link-local-sdk.mjs localsdk nocleanup start".

4. In src/hooks/useResolveWeb3Name.ts, there is a missing catch block after the then block in the getDomainName function to handle errors appropriately.

5. In src/hooks/useResolveWeb3Name.ts, there is a missing closing curly brace } for the getUnstoppableName function.

6. In src/hooks/useResolveWeb3Name.ts, the useEffect hook is missing some code due to snippets being replaced with ellipses (...). Make sure the missing parts are correctly implemented.

Other than these issues, the code looks good.

Please correct the mentioned issues above.

If you have any other specific concerns or questions, feel free to ask.