-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DMAPP-135: Push Chat Notification #150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Integrated chat notifications for both iOS and Android. - Converted the notification helper to use Context API for better state management. - Performed code refactoring to improve maintainability and readability.
- Removed unnecessary functions
- Updated Notifee notification configuration for group chat notifications to enhance appearance. - Refactored logic to remove chat notifications upon navigation to the chat history screen. This logic is now handled within the Single Chat component.
- Upgraded Firebase App, Messaging, and Notifee versions to fix the iOS native notification issue. - [System level]: Updated Android configuration to require JVM 17 for compatibility. - [Fix]: Resolved issue where the unlock profile modal was appearing after notification press even when the profile was already unlocked. - Made minor adjustments to Notifee display notification configuration.
- Handled rare case for missing notification data: navigates to the chat list instead of a specific chat. - Minor changes and fixes for improved reliability.
- Fixed navigation issue triggered on notification press.
Closed
- User can copy group Chat ID - Remove notification WIP
- Keep notification background handler in NotificationContext - [fix]: Resolve warning for Spam feed item key
rohitmalhotra1420
requested changes
Jan 10, 2025
- Requested code level changes done - Remove channel notifications from notification centre after read
rohitmalhotra1420
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user receives a new message, the application should display a notification based on the current app state:
App in Background (App Not Active/Minimized):
If the app is running in the background or closed, a system-level push notification banner will appear on the user’s device. This notification will display the new message, sender information, and any relevant metadata (e.g., message preview). The user can tap on the notification to bring the app to the foreground and view the message.
App in Foreground (App Opened and Active):
If the app is open and the user is on a different screen (not viewing the chat screen), the new message will trigger an in-app notification.
Documentation: Push chat notification