Merge pull request #51 from pusher/clean_up

Remove references to PHP
pusher · Jun 26, 2021 · 4f49ba7 · 4f49ba7
2 parents 193c744 + c7d5347
commit 4f49ba7
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 8 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -64,8 +64,7 @@ jobs:
         run: |
           export MAJOR=$(echo "${{ env.VERSION }}" | cut -d'.' -f1)
           export MINOR=$(echo "${{ env.VERSION }}" | cut -d'.' -f2)
-          sed -i "s|\"pusher/pusher-php-server\": \"^[0-9]*\.[0-9]*\"|\"pusher/pusher-php-server\": \"^${MAJOR}.${MINOR}\"|" README.md
-      - name: Prepare Pusher.php
+      - name: Prepare update
         run: |
           sed -i "s|\"version\": \"[^\"]*\"|\"version\": \"${{ env.VERSION }}\"|" package.json
           sed -i "s|const SDK_VERSION = '[^']*'|const SDK_VERSION = '${{ env.VERSION }}'|" push-notifications.js

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 1.2.4
+
+* [CHANGED] Remove some redundant steps from release action
+
 ## 1.2.3
 
 * [CHANGED] Switch from Travis CI to GH actions

diff --git a/__tests__/publishToInterests.test.js b/__tests__/publishToInterests.test.js
@@ -57,7 +57,7 @@ describe('publishToInterests', () => {
             expect(headers).toEqual({
                 authorization: 'Bearer SECRET_KEY',
                 accept: 'application/json',
-                'x-pusher-library': 'pusher-push-notifications-node 1.2.3',
+                'x-pusher-library': 'pusher-push-notifications-node 1.2.4',
                 host: 'instance_id.pushnotifications.pusher.com',
                 'content-type': 'application/json',
                 'content-length': 55
@@ -113,7 +113,7 @@ describe('publishToInterests', () => {
                 'content-type': 'application/json',
                 'content-length': 55,
                 authorization: 'Bearer SECRET_KEY',
-                'x-pusher-library': 'pusher-push-notifications-node 1.2.3',
+                'x-pusher-library': 'pusher-push-notifications-node 1.2.4',
                 host: 'instance_id.pushnotifications.pusher.com'
             });
             expect(body).toEqual({
@@ -201,7 +201,7 @@ describe('publishToInterests', () => {
                     'content-type': 'application/json',
                     'content-length': 1846,
                     authorization: 'Bearer 1234',
-                    'x-pusher-library': 'pusher-push-notifications-node 1.2.3',
+                    'x-pusher-library': 'pusher-push-notifications-node 1.2.4',
                     host: '1234.pushnotifications.pusher.com'
                 });
                 expect(body).toEqual({

diff --git a/__tests__/publishToUsers.test.js b/__tests__/publishToUsers.test.js
@@ -57,7 +57,7 @@ describe('publishToUsers', () => {
                 'content-type': 'application/json',
                 'content-length': 72,
                 authorization: 'Bearer SECRET_KEY',
-                'x-pusher-library': 'pusher-push-notifications-node 1.2.3',
+                'x-pusher-library': 'pusher-push-notifications-node 1.2.4',
                 host: 'instance_id.pushnotifications.pusher.com'
             });
             expect(body).toEqual({

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@pusher/push-notifications-server",
-    "version": "1.2.3",
+    "version": "1.2.4",
     "description": "NodeJS Server SDK for Pusher Push Notifications",
     "main": "push-notifications.js",
     "repository": "https://github.com/pusher/push-notifications-node",

diff --git a/push-notifications.js b/push-notifications.js
@@ -2,7 +2,7 @@ const jwt = require('jsonwebtoken');
 const http = require('http');
 const https = require('https');
 
-const SDK_VERSION = '1.2.3';
+const SDK_VERSION = '1.2.4';
 const INTERESTS_REGEX = new RegExp('^(_|\\-|=|@|,|\\.|;|[A-Z]|[a-z]|[0-9])*$');
 const {
     INTEREST_STRING_MAX_LENGTH,