Allow larger requests as we sometimes do on dedicated clusters #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damdo
reviewed
Jun 3, 2020
luismfonseca
force-pushed
the
allow-20kb-requests
branch
2 times, most recently
from
1c2e26b to
604329e
Compare
|
Any updates on this? We have a dedicated Pusher cluster with a 20 KB limit and have been bit by this a few times recently. Thanks! |
damdo
approved these changes
Jul 9, 2020
damdo
force-pushed
the
allow-20kb-requests
branch
from
604329e to
3e2eac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
While most customers will get requests reject if bigger than 10KB, we can let the server handle those errors. We don't want to allow bigger than 20KB due to bandwidth and overall cluster latency considerations, so we can move the hardcoded limit to match this.