Skip to content

Remove explicit app_id format validator #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove explicit app_id format validator #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions pusher/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import six

from pusher.util import ensure_text, ensure_binary, app_id_re
from pusher.util import ensure_text, ensure_binary
from pusher.crypto import parse_master_key


Expand All @@ -35,9 +35,6 @@ def __init__(
backend = RequestsBackend

self._app_id = ensure_text(app_id, "app_id")
if not app_id_re.match(self._app_id):
raise ValueError("Invalid app id")

self._key = ensure_text(key, "key")
self._secret = ensure_text(secret, "secret")

Expand Down