Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect usage of sys.getsizeof to calculate the byte size of event data #238

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Incorrect usage of sys.getsizeof to calculate the byte size of event data #238

wants to merge 1 commit into from

Conversation

guptag911
Copy link

[Incorrect usage of sys.getsizeof to calculate the byte size of event data
Fixes #236

What does this PR do?

As stated in the raised bug, the usage of sys.getsizeof function for getting the size of event_data was incorrect. Hence, I changed it to len.

  • [.] If you have changed dependencies, ensure both requirements.txt and setup.py have been updated

CHANGELOG

  • [CHANGED] Describe your change here. Look at CHANGELOG.md to see the format.

@evgeniibreikin
Copy link
Contributor

Hi, please cover with tests all possible edge cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect usage of sys.getsizeof to calculate the byte size of event data
2 participants
@guptag911 @evgeniibreikin