Add quckfix for three failing tests

puzzle · Feb 12, 2025 · add11ec · add11ec
1 parent a409596
commit add11ec
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 16 deletions.
diff --git a/app/helpers/person_helper.rb b/app/helpers/person_helper.rb
@@ -82,7 +82,7 @@ def sorted_people
   end
 
   def fetch_ptime_or_skills_data
-    all_skills_people = Person.all.map { |p| [p.name, person_path(p)] }
+    all_skills_people = Person.all.map { |p| [p.name, person_path(p, locale: I18n.locale)] }
     return all_skills_people unless Skills.ptime_available?
 
     ptime_employees = Ptime::Client.new.request(:get, 'employees', { per_page: 1000 })
@@ -112,8 +112,8 @@ def build_dropdown_data(ptime_employees)
       skills_person = Person.find_by(ptime_employee_id: ptime_employee[:id])
       ptime_employee_id = ptime_employee[:id]
       already_exists = ptime_employee_id.in?(Person.pluck(:ptime_employee_id))
-      path = new_person_path(ptime_employee_id: ptime_employee_id)
-      path = person_path(skills_person) if already_exists
+      path = new_person_path(ptime_employee_id: ptime_employee_id, locale: I18n.locale)
+      path = person_path(skills_person, locale: I18n.locale) if already_exists
 
       [ptime_employee_name, path]
     end

diff --git a/spec/helpers/person_helper_spec.rb b/spec/helpers/person_helper_spec.rb
@@ -7,9 +7,9 @@
       allow(Skills).to receive(:ptime_available?).and_return(true)
       skills_people = helper.fetch_ptime_or_skills_data
       expected = [
-        ["Longmax Smith", "/people/new?ptime_employee_id=33"],
-        ["Alice Mante", "/people/new?ptime_employee_id=21"],
-        ["Charlie Ford", "/people/new?ptime_employee_id=45"]
+        ["Longmax Smith", "/de/people/new?ptime_employee_id=33"],
+        ["Alice Mante", "/de/people/new?ptime_employee_id=21"],
+        ["Charlie Ford", "/de/people/new?ptime_employee_id=45"]
       ]
       expect(skills_people).to eq(expected)
     end
@@ -19,13 +19,13 @@
 
       skills_people = helper.fetch_ptime_or_skills_data
       expected = [
-        ["Bob Anderson", "/people/902541635"],
-        ["Alice Mante", "/people/663665735"],
-        ["ken", "/people/155397742"],
-        ["Charlie Ford", "/people/786122151"],
-        ["Wally Allround", "/people/790004949"],
-        ["Hope Sunday", "/people/247095502"],
-        ["Longmax Smith", "/people/169654640"]
+        ["Bob Anderson", "/de/people/902541635"],
+        ["Alice Mante", "/de/people/663665735"],
+        ["ken", "/de/people/155397742"],
+        ["Charlie Ford", "/de/people/786122151"],
+        ["Wally Allround", "/de/people/790004949"],
+        ["Hope Sunday", "/de/people/247095502"],
+        ["Longmax Smith", "/de/people/169654640"]
       ]
       expect(skills_people).to eq(expected)
     end
@@ -42,9 +42,9 @@
 
       dropdown_data = build_dropdown_data(ptime_employees_data)
       expected = [
-        ["Longmax Smith", "/people/169654640"],
-        ["Alice Mante", "/people/663665735"],
-        ["Charlie Ford", "/people/new?ptime_employee_id=45"]]
+        ["Longmax Smith", "/de/people/169654640"],
+        ["Alice Mante", "/de/people/663665735"],
+        ["Charlie Ford", "/de/people/new?ptime_employee_id=45"]]
       expect(dropdown_data).to eq(expected)
 
     end