Skip to content

Remove pandas series usage from ephemeris #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dfulu wants to merge 2 commits into
base: main
Choose a base branch
from
+30 −21
Open

Remove pandas series usage from ephemeris #2626

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4107429
Remove pandas series usage from ephemeris
dfulu Dec 16, 2025
68dd4f7
Fix line length
dfulu Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 30 additions & 21 deletions pvlib/solarposition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,34 +826,43 @@ def ephemeris(time, latitude, longitude, pressure=101325.0, temperature=12.0):

# Calculate refraction correction
Elevation = SunEl
TanEl = pd.Series(np.tan(np.radians(Elevation)), index=time_utc)
Refract = pd.Series(0., index=time_utc)

Refract[(Elevation > 5) & (Elevation <= 85)] = (
58.1/TanEl - 0.07/(TanEl**3) + 8.6e-05/(TanEl**5))

Refract[(Elevation > -0.575) & (Elevation <= 5)] = (
Elevation *
(-518.2 + Elevation*(103.4 + Elevation*(-12.79 + Elevation*0.711))) +
1735)
TanEl = np.tan(np.radians(Elevation))
Refract = np.zeros(len(time_utc))

mask = (Elevation > 5) & (Elevation <= 85)
Refract[mask] = (
58.1/TanEl[mask] - 0.07/(TanEl[mask]**3) + 8.6e-05/(TanEl[mask]**5))

mask = (Elevation > -0.575) & (Elevation <= 5)
Refract[mask] = (
Elevation[mask] * (
-518.2 + Elevation[mask]*(
103.4 + Elevation[mask]*(-12.79 + Elevation[mask]*0.711)
)
) + 1735
)

Refract[(Elevation > -1) & (Elevation <= -0.575)] = -20.774 / TanEl
mask = (Elevation > -1) & (Elevation <= -0.575)
Refract[mask] = -20.774 / TanEl[mask]

Refract *= (283/(273. + temperature)) * (pressure/101325.) / 3600.

ApparentSunEl = SunEl + Refract

# make output DataFrame
DFOut = pd.DataFrame(index=time_utc)
DFOut['apparent_elevation'] = ApparentSunEl
DFOut['elevation'] = SunEl
DFOut['azimuth'] = SunAz
DFOut['apparent_zenith'] = 90 - ApparentSunEl
DFOut['zenith'] = 90 - SunEl
DFOut['solar_time'] = SolarTime
DFOut.index = time

return DFOut
result = pd.DataFrame(
{
"apparent_elevation": ApparentSunEl,
"elevation": SunEl,
"azimuth": SunAz,
"apparent_zenith": 90 - ApparentSunEl,
"zenith": 90 - SunEl,
"solar_time": SolarTime,
},
index=time
)

return result


def calc_time(lower_bound, upper_bound, latitude, longitude, attribute, value,
Expand Down