Merged
Conversation
* Type `FPDF.title` correctly. * Allow paths as `fname` argument to `FPDF.add_font()`. * Use overloads for return type of `FPDF.output()`.
andersonhc
approved these changes
Feb 20, 2026
Collaborator
andersonhc
left a comment
andersonhc
left a comment
There was a problem hiding this comment.
Can you please add an entry on changelog.md?
Co-authored-by: Anderson Herzogenrath da Costa <andersonhc@gmail.com>
Added various type fixes including annotations and overloads.
Author
Done. I've used a second level of indentations, which hasn't been done before in the Changelog. Please let me know if I should flatten it or just merge the various entries into one. |
andersonhc
reviewed
Feb 21, 2026
andersonhc
approved these changes
Feb 21, 2026
Co-authored-by: Anderson Herzogenrath da Costa <andersonhc@gmail.com>
Collaborator
|
@allcontributors please add @srittau for code |
|
I've put up a pull request to add @srittau! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are a few random type fixes for issues encountered in my projects when migrating from types-fpdf2 to fpdf2 2.8.6:
FPDF.titlecorrectly.fnameargument toFPDF.add_font().FPDF.output().Checklist:
A unit test is covering the code added / modified by this PR N/A
In case of a new feature, docstrings have been added, with also some documentation in the
docs/folder N/AA mention of the change is present in
CHANGELOG.mdNot done yet. I assume there will be more type fixes before the next release, so maybe it's best if the maintainers write a summary? Otherwise, I can add an entry, if desired.
This PR is ready to be merged
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.