-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Chart Using PyGal added #762
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #762 +/- ##
=======================================
Coverage 92.67% 92.67%
=======================================
Files 27 27
Lines 7275 7275
Branches 1317 1317
=======================================
Hits 6742 6742
Misses 337 337
Partials 196 196 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@Lucas-C , the latest commit did not pass all the checks. Could not understand why it happened. Can you please guide me? |
It was nothing serious, there must have been a bit of heavy load on GitHub Actions runners and our performance tests failed to pass the configured execution time threshold. Re-running the failed tests should fix this. It has nothing to do with the content of your PR, so you really don't have to bother 😊 |
Merged! |
You would be very welcome! Also, if you have suggestions to improve the library, please share them 😊
Oh you men on this page? https://pyfpdf.github.io/fpdf2/index.html#tutorials |
By the way, the documentation section you added is now public! |
Pygal
documentation addedChecklist:
The GitHub pipeline is OK (green),
meaning that both
pylint
(static code analyzer) andblack
(code formatter) are happy with the changes of this PR.A unit test is covering the code added / modified by this PR
This PR is ready to be merged
In case of a new feature, docstrings have been added, with also some documentation in the
docs/
folderA mention of the change is present in
CHANGELOG.md
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.