Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contrib file): update to contributing and links to other resources #440

Merged
merged 7 commits into from
Feb 11, 2025

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Jan 21, 2025

This PR makes the contributing file more engaging and descriptive. it highlights this file as being a "Welcome mat" of sorts that invites contributors in and guides them through the process.

Let's try to merge this by Feb 3!! All feedback is welcome!

- Include instructions for the fork and pull request workflow, and link to resources or guides explaining these steps (if available).
- Guidelines that you have in place for users submitting issues, pull requests or asking questions.

If you have a [development guide](development-guide), link to it. This guide should provide clear instructions on how to set up your development environment locally. It also should overview and CI tools that you have that could simplify the contribution process (e.g. pre-commit.ci bot, etc), linters, code formatters, etc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you have a [development guide](development-guide), link to it. This guide should provide clear instructions on how to set up your development environment locally. It also should overview and CI tools that you have that could simplify the contribution process (e.g. pre-commit.ci bot, etc), linters, code formatters, etc.
If you have a [development guide](development-guide), link to it. This guide should provide clear instructions on how to set up your development environment locally. It also should overview local and CI tools that you have that could simplify the contribution process (e.g. pre-commit.ci bot, etc), linters, code formatters, etc.

Copy link
Contributor

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lwasser lwasser changed the title [feb 3 merge] feat(contrib file): update to contributing and links to other resources feat(contrib file): update to contributing and links to other resources Feb 11, 2025
@lwasser
Copy link
Member Author

lwasser commented Feb 11, 2025

Thank you everyone! i've incorporated all of the feedback and will merge this once CI is happy 🚀

@lwasser
Copy link
Member Author

lwasser commented Feb 11, 2025

@hugovk, may I add you to our GitHub "packaging council" GitHub team here so you can approve PR's?

@lwasser
Copy link
Member Author

lwasser commented Feb 11, 2025

The link failures here are unrelated to this PR. it could be because there have been some changes to the GitHub UI in the past weeks. I am going to merge for now.

@lwasser lwasser merged commit 51d0a0d into pyOpenSci:main Feb 11, 2025
3 of 4 checks passed
@lwasser lwasser deleted the contributing branch February 11, 2025 22:54
@hugovk
Copy link
Contributor

hugovk commented Feb 12, 2025

Yeah, we've skipped checking GitHub anchors in other projects.

(Sphinx, but for example: https://github.com/python/devguide/blob/b28d4de4d7bc79c199acdf3dfc19bd0dd0ff22fe/conf.py#L87-L92)

Also https://github.com/pyOpenSci/pyosMeta/blob/main/pyproject.toml#L60 is now currently pointing to an empty line. You can choose the correct line and select "Copy permalink" to get something more durable:

image

And the "Y" key is a shortcut for that, it'll replace main (or whatever branch) in the URL with something permanent.

@lwasser
Copy link
Member Author

lwasser commented Feb 13, 2025

oh wow - thanks. I didn't know about that! I don't want to ping her here, but I think Carol W set up something like that in one of our repos. i'll look into it. Thank you Hugo!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants