Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caravan interrupts and more #296

Open
wants to merge 56 commits into
base: master
Choose a base branch
from
Open

Conversation

O5MO
Copy link

@O5MO O5MO commented Feb 15, 2025

Added interrupts to caravans and made many improvements to caravan GUI.
Added and replaced some actions, which should make scheduling more versatile.
Fixed graphics being incorrect and adjusted selection boxes.
Complete with migrations and locale for EN, RU and UK languages
изображение

Also needs a new GUI style in PyCP (PR: pyanodon/pycoalprocessing#390)

Osmo added 30 commits January 22, 2025 23:29
… functioins to support that.

More work needs to be done
… fulfilled" instead of min/max.

But load and unload are still separate actions
@notnotmelon
Copy link
Contributor

Thank you! This is amazing!

@notnotmelon
Copy link
Contributor

notnotmelon commented Feb 24, 2025

Crash when waiting at a linked chest.

image

edit: resolved


-- Increase fuel inventory sizes
local old_inventory = caravan_data.fuel_inventory
local new_inventory = game.create_inventory(#old_inventory * 2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause issues. Caravans in previous versions had different inventory sizes than 1. I would recommend to instead import caravan-prototypes.lua from within the migration and set this value directly to prototype.fuel_size

elseif not only_outpost then
local position = event.cursor_position
schedule[#schedule + 1] = {
localised_name = {"caravan-gui.map-position", math.floor(position.x), math.floor(position.y)},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be entity.gps_tag
Using gps_tag allows this code to display the caravan's current planet, which is necessary for pySEx.

@notnotmelon
Copy link
Contributor

notnotmelon commented Feb 24, 2025

Missing locale

image

@notnotmelon
Copy link
Contributor

Bug: the "detonate" action is available for non-nuclear caravans.
image

@notnotmelon
Copy link
Contributor

Bug: if the caravan completes an action while this dropdown is open, the GUI breaks and the dropdown moves to an incorrect location.

image

@notnotmelon
Copy link
Contributor

Bug: These GUI icons in pyanodpedia do not match the updated icons for "open map" "open caravan", ect.

image

@notnotmelon
Copy link
Contributor

This PR requires an update to the caravan pyanodopedia before it can be merged.
image

@notnotmelon
Copy link
Contributor

Bug: I setup an interrupt "asd" to trigger on empty fuel. However once the condition was met it instead created a temp schedule for interrupt "Meat".

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants