-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helper functions for melonlib #68
base: main
Are you sure you want to change the base?
Conversation
…hnologies for recipes
…ting amounts absolutely instead of relatively
The implementation of replace_unlock won't preserve the order of unlocks as the replacement will always be added to the end of the list. Is this intentional? |
Also, set result amount and set ingredient amount can currently be accomplished with replace_ingredient and replace_result. I think your implementation could simply call those, if the shorthand is still necessary (I don't mind the addition). |
Come again? This simply removes it from the technology(s) in technology_old and adds it to the technology(s) in technology_new
Missed that, thanks. I'll update the PR. |
So if a tech unlocks recipe_a, recipe_b, and recipe_c, and you |
Some things that I noticed weren't included, and wouldn't necessarily be needed for the main mods but would significantly help with addons like pyblock and hardmode (and later pymods that need to modify earlier ones)