fix(cmake): NO_EXTRAS in pybind11_add_module function partially working
#5378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
NO_EXTRASparameter in thepybind11_add_modulefunction was not fully effective, resulting in incomplete application of the intended build configuration. After investigation, it was discovered that thetarget_link_libraries(${target_name} PRIVATE pybind11::windows_extras)command was included twice in the CMake script. One of these instances occurred before theARG_NO_EXTRAScondition was checked, which causedpybind11::windows_extrasto be linked even whenNO_EXTRASwas set. Another occurrence of this call can be found here. This caused the function to work only partially as intended.Suggested changelog entry: