chore: use scikit-build-core for the build #5598
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
henryiii/feat/skbc
branch
6 times, most recently
from
d8188d9 to
098e77b
Compare
jcfr
reviewed
Apr 4, 2025
jcfr
reviewed
Apr 4, 2025
Explain how results previously obtained by setting |
|
As for the explanation, I think that should go in the upgrade guide. |
henryiii
force-pushed
the
henryiii/feat/skbc
branch
from
4eebc66 to
08a874a
Compare
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/feat/skbc
branch
from
08a874a to
855e26b
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/feat/skbc
branch
from
855e26b to
d9d3774
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches to scikit-build-core from setuptools. Using PEP 639 licence.
Still need to update tests to restore checking the generated files, and figure out a way to pin
[global]topybind11-global.Suggested changelog entry:
* Use scikit-build-core for the build backend. The CMake generation has been moved to the sdist->wheel step. ``PYBIND11_GLOBAL_PREFIX`` has been removed.