verification/policy: make subject optional internally #10335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not surfaced in a public API yet; it's purely an internal change to enable a `ClientVerifier` API (which won't take a subject). Signed-off-by: William Woodruff <[email protected]>
woodruffw
commented
Feb 3, 2024
Comment on lines
+307
to
+311
| if !policy | ||
| .subject | ||
| .as_ref() | ||
| .map_or_else(|| false, |sub| sub.matches(&san)) | ||
| { |
There was a problem hiding this comment.
NB: This fails closed if the surrounding Policy doesn't have a configured subject. AFAICT this is the only reasonable behavior, since the SAN extension verifier here only makes sense when a subject is supplied by the user.
(In the context of a new ClientVerifier API, we'll need a different SAN extension verifier.)
alex
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not surfaced in a public API yet; it's purely an internal change to enable a
ClientVerifierAPI (which won't take a subject).See #10276.