Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new arguments-v3 schema #1641

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add new arguments-v3 schema #1641

wants to merge 4 commits into from

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Feb 20, 2025

Change Summary

Fixes pydantic/pydantic#11240

The new arguments schema allow to validate mappings (both from JSON and Python) differently (see issue), but still validates ArgsKwargs instances in Python mode as it does with the existing arguments schema.

Related issue number

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

codspeed-hq bot commented Feb 20, 2025

CodSpeed Performance Report

Merging #1641 will not alter performance

Comparing new-arguments-schema (e442d7d) with main (9975030)

Summary

✅ 157 untouched benchmarks

@Viicos Viicos force-pushed the new-arguments-schema branch 2 times, most recently from 2aadb68 to 8148d18 Compare February 27, 2025 12:00
@Viicos Viicos force-pushed the new-arguments-schema branch from 4c08142 to 1555034 Compare February 27, 2025 17:13
@Viicos Viicos changed the title Add new arguments schema Add new arguments-v3 schema Feb 27, 2025
@Viicos Viicos marked this pull request as ready for review February 27, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New JSON validation mode for callables
1 participant