Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load FontAwesome script at end of body #2116

Closed
wants to merge 1 commit into from
Closed

Load FontAwesome script at end of body #2116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,15 @@ function macroTemplate({ compilation }) {
{% endmacro %}

{% macro head_js_preload() %}
<!-- So that users can add custom icons -->
${fa_scripts.map(script.bind(compilation)).join("\n")}
<!-- Pre-loaded scripts that we'll load fully later -->
${theme_scripts.map(preloadScript.bind(compilation)).join("\n")}
{% endmacro %}

{% macro body_post() %}
<!-- Scripts loaded after <body> so the DOM is not blocked -->
${theme_scripts.map(deferScript.bind(compilation)).join("\n")}
<!-- So that users can add custom icons -->
${fa_scripts.map(script.bind(compilation)).join("\n")}
{% endmacro %}
`);
}
Expand Down
Loading