Add typos check to pre-commit hooks #10040
Conversation
Also fixes a bunch of typos. The work here was adding the exclusions (I had an LLM do them but also checked them)
pyproject.toml
Outdated
| @@ -63,6 +57,22 @@ io = [ | |||
| etc = ["sparse"] | |||
| parallel = ["dask[complete]"] | |||
| viz = ["cartopy", "matplotlib", "nc-time-axis", "seaborn"] | |||
| type-stubs = [ | |||
There was a problem hiding this comment.
I had meant to add this in a separate PR; I can do that if folks prefer / we need any discussion on it
| @@ -73,3 +73,9 @@ repos: | |||
| hooks: | |||
| - id: validate-pyproject | |||
| additional_dependencies: ["validate-pyproject-schema-store[all]"] | |||
| - repo: https://github.com/crate-ci/typos | |||
There was a problem hiding this comment.
This is the typos project — it's great in PRQL. There's also a new-ish VSCode extension which has been good
|
Does anyone know what is "better", this or codespell #9781? |
Oh no! I didn't mean to come along with a different version. I have had a great experience with I guess at least this passes pre-commit? :) |
|
You could add [tool.typos.type.jupyter]
extend-ignore-re = [
"\"id\": \".*\"",
]to avoid correcting hashes in jupyter notebooks (crate-ci/typos#415 (comment)) |
|
To get something in, I'll merge this. But if anyone has a strong view on this vs codespell, please feel free to switch, no complaint from me... |
for more information, see https://pre-commit.ci
* main: (67 commits) Refactor datetime and timedelta encoding for increased robustness (pydata#9498) Fix test_distributed::test_async (pydata#10138) Refactor concat / combine / merge into `xarray/structure` (pydata#10134) Split `apply_ufunc` out of `computation.py` (pydata#10133) Refactor modules from `core` into `xarray.computation` (pydata#10132) Refactor compatibility modules into xarray.compat package (pydata#10131) Fix type issues from pandas stubs (pydata#10128) Don't skip tests when on a `mypy` branch (pydata#10129) Change `python_files` in `pyproject.toml` to a list (pydata#10127) Better `uv` compatibility (pydata#10124) explicitly cast the dtype of `where`'s condition parameter to `bool` (pydata#10087) Use `to_numpy` in time decoding (pydata#10081) Pin pandas stubs (pydata#10119) Fix broken Zarr test (pydata#10109) Update asv badge url in README.md (pydata#10113) fix and supress some test warnings (pydata#10104) Improve handling of dtype and NaT when encoding/decoding masked and packaged datetimes and timedeltas (pydata#10050) Ensure KeyError raised for zarr datasets missing dim names (pydata#10025) Add typos check to pre-commit hooks (pydata#10040) Bump codecov/codecov-action from 5.3.1 to 5.4.0 in the actions group (pydata#10090) ...
Also fixes a bunch of typos. The work here was adding the exclusions (I had an LLM do them but also checked them)