Skip to content

Allow pydap to use dims or dimensions #10234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Allow pydap to use dims or dimensions #10234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions xarray/backends/pydap_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,12 @@ def open(

def open_store_variable(self, var):
data = indexing.LazilyIndexedArray(PydapArrayWrapper(var))
return Variable(var.dimensions, data, _fix_attributes(var.attributes))
# dimensions was renamed in https://github.com/pydap/pydap/pull/481
try:
dims = var.dimensions
except AttributeError:
dims = var.dims
return Variable(dims, data, _fix_attributes(var.attributes))

def get_variables(self):
return FrozenDict(
Expand All @@ -142,7 +147,12 @@ def get_attrs(self):
return Frozen(_fix_attributes(self.ds.attributes))

def get_dimensions(self):
return Frozen(self.ds.dimensions)
# dimensions was renamed in https://github.com/pydap/pydap/pull/481
try:
dims = self.ds.dimensions
except AttributeError:
dims = self.ds.dims
return Frozen(dims)


class PydapBackendEntrypoint(BackendEntrypoint):
Expand Down
Loading