Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get working with v3 #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

get working with v3 #4

wants to merge 1 commit into from

Conversation

rod7760
Copy link

@rod7760 rod7760 commented Aug 1, 2024 •
edited
Loading

Changelog

[Added]
    * pyproject.toml to package project
    * various missing utility functions
    * missing fact and operation tests from pyinfra
[Fixed]
    * WinRMConnector now works with v3
    * Got test_winrm_connector working

Run Tests

hatch run test:all

Notes

  • missing linting
  • many existing TODOs left

rod7760
rod7760 commented Aug 1, 2024
View reviewed changes
pyinfra_windows/operations/files.py
remote_dirname,
state=state,
host=host,
#state=state, # TODO not sure why these args are here
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why state and host are here? Directory's args don't contain them

@rod7760
Copy link
Author

rod7760 commented Aug 1, 2024 •
edited
Loading

I have a couple of TODOs with questions here. I just wanted to get some input before cleaning up.

rod7760
rod7760 commented Aug 1, 2024
View reviewed changes
pyproject.toml
build-backend = "hatchling.build"

[project]
version = "0.0.1"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this version ok?

@rod7760 rod7760 marked this pull request as draft August 3, 2024 20:33
@rod7760 rod7760 force-pushed the package-pyinfra-windows branch from 03753a0 to b7a6ed1 Compare August 3, 2024 21:27
@rod7760
Copy link
Author

rod7760 commented Aug 3, 2024

No idea how to add the github actions before merge...

Here is a link to the actions results for reference:
https://github.com/rod7760/pyinfra-windows/actions/workflows/test.yml

@rod7760
[Added]
a8b9397 
* pyproject.toml to package project
* various missing utility functions
* missing fact and operation tests from pyinfra
[Fixed]
* WinRMConnector now works with v3
* Got test_winrm_connector working
@rod7760 rod7760 force-pushed the package-pyinfra-windows branch from 0ab763c to a8b9397 Compare August 3, 2024 21:53
@rod7760 rod7760 marked this pull request as ready for review August 3, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rod7760