Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: Add pypy3.11 to testing matrix #10287

Merged
merged 11 commits into from
Mar 25, 2025

Conversation

aaronliu0130
Copy link
Contributor

idea by @cclauss. See also #10286; we maintain the same project.

Type of Changes

Type
uhhhh i don't think anything applies‽

idea by @cclauss
Co-authored-by: Christian Clauss <[email protected]>
@aaronliu0130
Copy link
Contributor Author

aaronliu0130 commented Mar 18, 2025

Also, the only problem we had was with pypy-3.11 on Windows. It obtained the latest version of pytest without issue on other platforms and CPython, but on Windows, it said there was no suitable version on PyPI despite Pylint being platform-independent:

ERROR: No matching distribution found for pylint>=3.3.5; extra == "dev"

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (67b3661) to head (1811783).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #10287   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files         175      175           
  Lines       19073    19073           
=======================================
  Hits        18290    18290           
  Misses        783      783           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This comment has been minimized.

@Pierre-Sassoulas Pierre-Sassoulas added Blocked 🚧 Blocked by a particular issue Maintenance Discussion or action around maintaining pylint or the dev workflow labels Mar 19, 2025
@Pierre-Sassoulas Pierre-Sassoulas added this to the 4.0.0 milestone Mar 19, 2025
@cclauss
Copy link
Contributor

cclauss commented Mar 22, 2025

Could a project maintainer please rerun the pypy3.10 test? That should not fail.

@Pierre-Sassoulas
Copy link
Member

pypy 3.10 often fail for hard to understand reasons, so it's not unusual.

@cclauss
Copy link
Contributor

cclauss commented Mar 24, 2025

Please rebase.

@Pierre-Sassoulas Pierre-Sassoulas removed the Blocked 🚧 Blocked by a particular issue label Mar 24, 2025

This comment has been minimized.

@Pierre-Sassoulas
Copy link
Member

Support for a new interpreter deserves a changelog entry :)

This comment has been minimized.

@aaronliu0130
Copy link
Contributor Author

I didn't realize pypy3.11 tests work now! That wasn't me though (this just adds them to testing), and I don't think previous addition of new pypy interpreters to the testing matrix had changelogs.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@aaronliu0130
Copy link
Contributor Author

Actions failure seems to be an environmental problem.

@Pierre-Sassoulas
Copy link
Member

Other PR are failing with this, I'm going to try to merge one where the changelog check can't fail and see how it goes when rebasing on it (well merge because there's conflict on this branch). I'll deal with this don't worry.

This comment has been minimized.

This comment has been minimized.

@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) March 25, 2025 09:46
@Pierre-Sassoulas Pierre-Sassoulas merged commit 3457433 into pylint-dev:main Mar 25, 2025
35 checks passed
Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 1811783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants