Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Simplify tests using matrix.os #10299

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Mar 22, 2025

Use matrix.os and matrix.include to consolidate the GitHub Actions jobs tests-linux, tests-macos, and tests-pypy into a single tests job.

Removes 80+ lines of duplicate configuration.

Type of Changes

Type
🔨 Refactoring

Description

Refs #10288

Closes #XXXX

This comment has been minimized.

@cclauss cclauss force-pushed the github/workflows/tests.yaml-matrix.os branch from 85e8971 to 946c0fe Compare March 22, 2025 11:54

This comment has been minimized.

@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Mar 22, 2025
@cclauss cclauss force-pushed the github/workflows/tests.yaml-matrix.os branch from 6afbf32 to 6942e7c Compare March 22, 2025 15:18
@cclauss
Copy link
Contributor Author

cclauss commented Mar 22, 2025

The required test run / 3.11 / Linux test has been renamed to Tests / run / 3.11 / ubuntu-latest.
image

@mbyrnepr2 Your review, please.

Copy link

codecov bot commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (a3e5bef) to head (6942e7c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10299      +/-   ##
==========================================
+ Coverage   95.86%   95.89%   +0.02%     
==========================================
  Files         175      175              
  Lines       19074    19074              
==========================================
+ Hits        18286    18291       +5     
+ Misses        788      783       -5     

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 6942e7c

@webknjaz
Copy link
Contributor

The required test run / 3.11 / Linux test has been renamed to Tests / run / 3.11 / ubuntu-latest.

(🔌 shameless plug) https://github.com/marketplace/actions/alls-green#why would've made such transitions smoother.

@Pierre-Sassoulas Pierre-Sassoulas merged commit a5f6765 into pylint-dev:main Mar 24, 2025
34 checks passed
@cclauss cclauss deleted the github/workflows/tests.yaml-matrix.os branch March 24, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants