Fix crash caused by invalid format strings in .format context
#10300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #10300 +/- ##
=======================================
Coverage 95.86% 95.86%
=======================================
Files 175 175
Lines 19074 19074
=======================================
Hits 18286 18286
Misses 788 788
π New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 2b16fcf |
Pierre-Sassoulas
approved these changes
Mar 23, 2025
Comment on lines
-415
to
+425
| if isinstance(keyword, nodes.Dict): | ||
| if len(keyword.items) > 1 and len(keyword_args) > 1: | ||
| return | ||
| if ( | ||
| isinstance(keyword, nodes.Dict) | ||
| and len(keyword.items) > 1 | ||
| and len(keyword_args) > 1 | ||
| ): | ||
| return |
|
I don't know what's wrong with the failing job, seems like a cache issue where pylint 4.0.0dev0 doesn't refer to the same commit ? |
zenlyj
changed the title
.format context.format context
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Mar 24, 2025
β¦) (#10302) (cherry picked from commit e6cbd41) Co-authored-by: Zen Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This PR addresses a crash in the
consider-using-f-stringcheck that occurs when.formatis used with keyword arguments and the format string is malformed. Theutils.parse_format_method_stringraises an uncaughtIncompleteFormatStringexception, leading to the unexpected crash.Another observation is
consider-using-f-stringis raised when.formatis used with positional arguments:In such cases, it seems more appropriate to suppress
consider-using-f-string, since thebad-format-stringmessage already covers the issue.Closes #10282