[Backport maintenance/3.3.x] Speed up the generation of no-member suggestions #10311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Previously, edit distances were calculated for strings that had length differences greater than the maximum suggestion threshold. Remove handling of missing-member-hint-distance = 0 Co-authored-by: Pierre Sassoulas <[email protected]> (cherry picked from commit 9a6168d)
Pierre-Sassoulas
approved these changes
Mar 25, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## maintenance/3.3.x #10311 +/- ##
==================================================
Coverage 95.84% 95.84%
==================================================
Files 174 174
Lines 18984 18993 +9
==================================================
+ Hits 18195 18204 +9
Misses 789 789
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 9a6168d from #10277.