-
-
Notifications
You must be signed in to change notification settings - Fork 269
Ordinal regression #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ordinal regression #533
Conversation
…rdered univariate transform
…rdered univariate transform
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Marking this one as ready for a pull request because I think i have the bones of what I want... but not quite the structure. I also know @drbenvincent has thoughts on this one too. So opening it up for feeback or pushback, suggestions Broad structure at the moment is
|
Great stuff. Reviewing this and the other notebook is definitely on my list 🙂 |
I hope to have time to review this Friday or Monday. Feel free to ping me if I violate that 🫠 |
Giving this one a nudge @drbenvincent |
Thanks for the reminder. A bunch of house move things get finished today, so should have capacity for this very soon :) |
Just giving another nudge here @drbenvincent. At this point i'm pretty happy with it. |
Sorry, taking a look now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- In the intro, add wikipedia link to Likert scale page
- Could potentially add seed for RNG in the
make_data
function. But entirely optional - Can we easily remove the
Unnamed: 0
column indf
? - Where it says "brainchild of Dr Ben Vincent", add Adrian Seyboldt also. I can't quite remember how it came about, but it was some mix of both of us.
- Could add some alpha to the histogram plots
- Change "Normal V Uniform Priors" title to say "versus"
- Comparison to
statsmodels
is nice, but could have a short description to focus the reader to any salient points. - Plot under heading "Interrogating the Model's Implications" is cool but could perhaps have a brief explanation.
- Update dates to June 2023 (sorry)
Very nice 👍
Made those changes. Think we're all good now. Thanks for the review! |
Example Notebook using Ordinal Regression Model
Related to this issue: #277
Notebook is a work in progress. Just experimenting with different model specifications on fake data with known properties.
Current plan is fit and explain the regression model with a discussion of the priors over the cut points and evaluating different implications of the model specification. Rough plan is to then apply the techniques to examples in Agresti's book on categorical data analysis.
Helpful links