Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dustin Stansbury's statistical rethinking notebooks #754 #770

Merged
merged 6 commits into from
Feb 18, 2025

Conversation

fonnesbeck
Copy link
Member

@fonnesbeck fonnesbeck commented Feb 2, 2025

Adds Dustin's notebooks to the examples, adapting the style accordingly.

Helpful links


📚 Documentation preview 📚: https://pymc-examples--770.org.readthedocs.build/en/770/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@fonnesbeck
Copy link
Member Author

Moved from #754

If there are no critical problems, I suggest we merge them as-is and make additional changes in separate PRs.

@bwengals
Copy link
Collaborator

bwengals commented Feb 4, 2025

That sounds good. There's an issue with the GP example, I left a comment there, but I'm good w picking that up later.

@jessegrabowski
Copy link
Member

The plan is no longer to have them appear in the gallery?

@fonnesbeck
Copy link
Member Author

Sorry! Fixed.

@aloctavodia
Copy link
Member

Overall LGTM.

Chapter 16 and 17 mention "PyMC5". In Chapter 17 it is mentioned that pymc/pytensor uses a naive implementation log_sum_exp , is that the case?

@fonnesbeck
Copy link
Member Author

It appears to be true

@fonnesbeck fonnesbeck merged commit da49b3a into pymc-devs:main Feb 18, 2025
2 checks passed
@fonnesbeck fonnesbeck deleted the statistical_rethinking_lectures branch February 18, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants