Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BART Hawks NBs with new plots #775

Merged
merged 4 commits into from
Mar 11, 2025
Merged

Conversation

AlexAndorra
Copy link
Collaborator

@AlexAndorra AlexAndorra commented Feb 16, 2025

  • Add softmax_link to plot_pdp to visualize the partial probabilities
  • Add new plot_scatter_submodels

NB: this needs new features from PyMC BART, introduced here


📚 Documentation preview 📚: https://pymc-examples--775.org.readthedocs.build/en/775/

@AlexAndorra AlexAndorra added the enhancement New notebook planned to be added to the collection label Feb 16, 2025
@AlexAndorra AlexAndorra self-assigned this Feb 16, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

review-notebook-app bot commented Feb 17, 2025

View / edit / reply to this conversation on ReviewNB

aloctavodia commented on 2025-02-17T06:24:23Z
----------------------------------------------------------------

Use func argument to pass the softmax


AlexAndorra commented on 2025-02-17T22:16:44Z
----------------------------------------------------------------

Addressed

Copy link

review-notebook-app bot commented Feb 17, 2025

View / edit / reply to this conversation on ReviewNB

aloctavodia commented on 2025-02-17T06:24:24Z
----------------------------------------------------------------

definetelly nicer!


Copy link

review-notebook-app bot commented Feb 17, 2025

View / edit / reply to this conversation on ReviewNB

aloctavodia commented on 2025-02-17T06:24:24Z
----------------------------------------------------------------

Not for this PR. But this is the kind of plot we should replace with a proper calibration plot (as implemented in ArivZ 1.0!).


AlexAndorra commented on 2025-02-17T14:32:19Z
----------------------------------------------------------------

Completely agree. I'll edit this NB again once I get my calibration plot into ArviZ (if that's the plot you're talking about)

aloctavodia commented on 2025-02-18T07:12:46Z
----------------------------------------------------------------

I am talking about calibration plots in general, like yours or others like https://arviz-plots.readthedocs.io/en/latest/gallery/plot_pava_calibration.html

AlexAndorra commented on 2025-02-19T01:13:49Z
----------------------------------------------------------------

Definitely. Actually, is this one ready for me to add it here?

aloctavodia commented on 2025-03-10T15:51:23Z
----------------------------------------------------------------

The calibration plot in arviz currently does not support checking the levels. The suggestion is to do it by using a One vs Others approach

Copy link
Collaborator Author

Completely agree. I'll edit this NB again once I get my calibration plot into ArviZ (if that's the plot you're talking about)


View entire conversation on ReviewNB

Copy link
Collaborator Author

Addressed


View entire conversation on ReviewNB

@AlexAndorra
Copy link
Collaborator Author

Addressed your comments @aloctavodia

Copy link
Member

I am talking about calibration plots in general, like yours or others like https://arviz-plots.readthedocs.io/en/latest/gallery/plot_pava_calibration.html


View entire conversation on ReviewNB

Copy link
Collaborator Author

Definitely. Actually, is this one ready for me to add it here?


View entire conversation on ReviewNB

@AlexAndorra
Copy link
Collaborator Author

Updated with the latest changes on pymc-bart's PR @aloctavodia

Copy link
Member

The calibration plot in arviz currently does not support checking the levels. The suggestion is to do it by using a One vs Others approach


View entire conversation on ReviewNB

@aloctavodia aloctavodia merged commit 43d6c3a into main Mar 11, 2025
2 checks passed
@aloctavodia aloctavodia deleted the update-bart-categorical branch March 11, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New notebook planned to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants