Fix for #3310 and some more #3319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ps broadcasting multiple rvs calls with different size and distribution parameter shapes. Added shape guards to other continuous distributions.
…t a parameter shape aware size input thanks to generate_samples.
junpenglao
reviewed
Dec 21, 2018
RELEASE-NOTES.md
Outdated
| @@ -36,6 +36,8 @@ This will be the last release to support Python 2. | |||
| - Fixed `Rice` distribution, which inconsistently mixed two parametrizations (#3286). | |||
| - `Rice` distribution now accepts multiple parameters and observations and is usable with NUTS (#3289). | |||
| - `sample_posterior_predictive` no longer calls `draw_values` to initialize the shape of the ppc trace. This called could lead to `ValueError`'s when sampling the ppc from a model with `Flat` or `HalfFlat` prior distributions (Fix issue #3294). | |||
| - Added the `broadcast_distribution_samples` function that helps broadcasting arrays of drawn samples, taking into account the requested `size` and the inferred distribution shape. This sometimes is needed by distributions that call several `rvs` separately within their `random` method, such as the `ZeroInflatedPoisson` (Fix issue #3310). | |||
There was a problem hiding this comment.
Should be under the new release note (v3.6)
junpenglao
reviewed
Dec 21, 2018
pymc3/distributions/continuous.py
Outdated
| @@ -964,6 +965,11 @@ def random(self, point=None, size=None): | |||
| """ | |||
| mu, lam, alpha = draw_values([self.mu, self.lam, self.alpha], | |||
| point=point, size=size) | |||
| print(mu.shape, lam.shape, alpha.shape) | |||
There was a problem hiding this comment.
dont forget to remove the print
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
broadcast_distribution_samples, which helps broadcasting multiple rvs calls with differentsizeand distribution parameter shapes. Added shape guards to other continuous distributions. In particular, this fixes #3310, but it also prevents similar things from happening in other discrete and continuous distributions that could encounter the same pathological behavior.