Skip to content

Conversation

@adamboche
Copy link
Contributor

Resolving #3381, by adding an eval_env argument to from_formula, based on https://patsy.readthedocs.io/en/latest/API-reference.html#patsy.dmatrix.

Copy link
Member

@lucianopaz lucianopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thanks so much for the contribution! I think it's great! I have some comments though.

This change should be noted in the RELEASE-NOTES.md features section.

@lucianopaz lucianopaz merged commit 6f7fafa into pymc-devs:master Feb 27, 2019
@lucianopaz
Copy link
Member

@adamboche, thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants