-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Rerun notebooks #3397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rerun notebooks #3397
Conversation
I will help. |
Also, we might want to prioritize those notebook have not been run for a while. |
I will run the |
How can we tell which one hasn't been run in a while? |
Via https://serverfault.com/questions/401437/how-to-retrieve-the-last-modification-date-of-all-files-in-a-git-repository and some messing around: git ls-tree -r --name-only HEAD | grep notebooks | while read filename; do echo "$(git log -1 --format="%ai" -- $filename) $filename"; done | sort |
|
This might be an opportunity to retire notebooks that are either redundant or are not well-annotated. I think the suite is currently too big. Might be worth considering moving most of them to the pymc resources repo. |
|
@twiecki, sorry for late update, let me have a look this night |
Do you mean bad documented? |
Yeah exactly. I think it's quite difficult to follow.
…On Tue, Mar 26, 2019, 22:04 Maxim Kochurov ***@***.***> wrote:
Do you mean bad documented?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3397 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AApJmHrRMLuhrGv-nh4wIxD2mrM-8QFpks5vaotXgaJpZM4bmfnE>
.
|
I did a rebase, hopefully did not mess up anything... |
This is blocking our release - should we split the effort and run the essential notebooks? |
I would say definitively the GP ones should be rerun |
@junpenglao if Empirical notebook is a concern, I can take it later and move them to inline docs. For now it is better option to leave it as is and open an issue. PS I'm on vacations now |
98e5746
to
6ea7444
Compare
The Dawid-Skene notebook is fairly OK I remember - any reason why removing it? |
I couldn't run it and gave up, if we figure it out should be fine.
…On Wed, Apr 24, 2019, 13:09 Junpeng Lao ***@***.***> wrote:
The Dawid-Skene notebook is fairly OK I remember - any reason why removing
it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3397 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAFETGDPWOBXGIRQGNDPACDPSA5XTANCNFSM4G4Z7HCA>
.
|
…into rerun_notebooks
Oh nice @lucianopaz ! I think we are finally ready to merge and do a release? |
Only the big manualoa2 is left, which takes like a full day to run |
Releasewise, I would really like #3456 to make it into the release |
Is anyone planning on running that one? I can run it on my desktop and leave it on all day |
Will push manualoa2 if it finishes running on my desktop and merge in a separate branch |
Trying to rerun all notebooks but been running into tons of errors because basically api changes in multiple libraries are breaking a bunch of the notebooks.
I'll push changes here and check off the ones that I have running. If anyone wants to help out thatd be great!
My current env