Skip to content

fix the issue 3428 #3426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix the issue 3428 #3426

wants to merge 1 commit into from

Conversation

chang111
Copy link
Contributor

As for the request from the @lucianopaz .
I start a new pr to make the pr clean.
This pr is the copy from the previous pr 3250 with a little change that I reset the 'test_truncated_normal_lower' and the 'test_truncated_normal_upper'

@junpenglao
Copy link
Member

Hi @chang111, I appreciate your effort to fix issues! However, since in #3250 most work has been done, it would not be fair to the origin author that you just copy his/her changes here. So unless you have a new solution, the recommend practice is:

  1. make sure nobody is still working on changed default values for TruncatedNormal lower and upper from None to -np.inf… #3250;
  2. if you want to finish changed default values for TruncatedNormal lower and upper from None to -np.inf… #3250, push directly to the branch in changed default values for TruncatedNormal lower and upper from None to -np.inf… #3250
  3. after review and merge, both you and the origin author will be credited in the merge message. It is only fair that everybody's contributions are recognized!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants