Fix positional arguments for Bounded RVs #3446
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3399 .
*args
fromBound.__call__
was mixing with parameters passed to_ContinuousBounded
. i.eHere
*args
was supposed to be arguments for thedistribution
but dist.init will put positional arguments*args
before keyword arguments when calling the constructor for_ContinuousBounded
, thus mixing the arguments.I have changed all calls to the
_ContinuousBounded
constructor to use only (and all) positional arguments. Also added a test to reproduce the issue