-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Reformat continuous.py #4051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformat continuous.py #4051
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4051 +/- ##
=======================================
Coverage 88.47% 88.48%
=======================================
Files 88 88
Lines 13860 13865 +5
=======================================
+ Hits 12263 12268 +5
Misses 1597 1597
|
Some of the Black formatting I am not sure it is making the code better or worse 😂 |
Ha ha yeah, I see what you mean! I think this is always a trade-off though, as it also makes some parts of the code much clearer -- so I hope on balance it's better 😅 Thanks a lot for all these reformatting proposals, I'll look at that ASAP! |
…us-py Merge branch master to update PR.
Turns out the "ASAP" was a bit long this time around, but I added your suggested reformattings @junpenglao 😉 |
Fixing merge conflicts then self-merging if nobody has strong feelings against this reformatting -- to avoid further merge conflicts |
Black is making some of the lines worse to read as @junpenglao mentioned, but knowing how black doesn't care about our feelings Im not sure what you can do about it |
As discussed in #4049, this PR cleans up
continuous.py
for better readability of the code:import
statements according to PEP8In addition, @junpenglao mentioned repeating bits that could be refactored. Do you have specific places in mind Junpeng?
I can make the changes or you can push directly on this PR -- whatever you prefer 🙂
RELEASE-NOTES.md