-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Allow for scalar or size 1 mu
in MvNormal
and MvStudentT
#5386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5386 +/- ##
==========================================
- Coverage 80.44% 80.40% -0.05%
==========================================
Files 82 82
Lines 14132 14154 +22
==========================================
+ Hits 11369 11380 +11
- Misses 2763 2774 +11
|
8298933
to
f4bf575
Compare
f4bf575
to
24ef5c7
Compare
* If custom tests start with `test_` they would have run twice, once called by the `BaseTestDistribution` and once by `pytest` * For consistency rename `tests_to_run` to `checks_to_run` * Also fixes TestWald hack which unnecessarily overrode bast class methods
24ef5c7
to
d28fff5
Compare
Failing test is flaky: #5411 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
We may need to revisit here after #5383 gets solved, because if cov
parameter supports batch dimensions, it may require broadcasting against mu
.
Yeah. Let's do it. |
Just for user friendliness, as this was accepted in V3