Skip to content

Automatically resize sd_dist in _LKJCholeskyCov #5534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

ricardoV94
Copy link
Member

Closes #5441

@ricardoV94 ricardoV94 requested a review from fonnesbeck March 3, 2022 10:22
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #5534 (9109c65) into main (a92a414) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5534      +/-   ##
==========================================
+ Coverage   87.24%   87.27%   +0.03%     
==========================================
  Files          81       81              
  Lines       14258    14246      -12     
==========================================
- Hits        12439    12433       -6     
+ Misses       1819     1813       -6     
Impacted Files Coverage Δ
pymc/distributions/multivariate.py 92.18% <100.00%> (+0.02%) ⬆️
pymc/parallel_sampling.py 86.71% <0.00%> (-1.00%) ⬇️
pymc/model.py 85.93% <0.00%> (ø)
pymc/backends/report.py 91.04% <0.00%> (+1.31%) ⬆️
pymc/sampling_jax.py 98.42% <0.00%> (+1.52%) ⬆️
pymc/bart/utils.py 85.40% <0.00%> (+2.79%) ⬆️

@ricardoV94 ricardoV94 force-pushed the resize_lkj_sd_dists branch 2 times, most recently from fdda190 to fc8c201 Compare March 4, 2022 08:56
@ricardoV94 ricardoV94 force-pushed the resize_lkj_sd_dists branch from fc8c201 to 9109c65 Compare March 7, 2022 14:42
@ricardoV94 ricardoV94 merged commit f71a2b1 into pymc-devs:main Mar 7, 2022
@ricardoV94 ricardoV94 deleted the resize_lkj_sd_dists branch March 11, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sampling from model with LKJCholeskyCov raises ValueError
2 participants