Skip to content

Implement gradient support for complex types #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
educhesne opened this issue Apr 14, 2025 · 1 comment
Open

Implement gradient support for complex types #1366

educhesne opened this issue Apr 14, 2025 · 1 comment

Comments

@educhesne
Copy link
Contributor

educhesne commented Apr 14, 2025

Description

The question arose in PR #1303 to support complex gradient.

There are two conventions regarding complex gradient:

  • the holomorphic compatible gradient, as in JAX
  • its conjugate, the gradient-descent compatible gradient, as in torch

At the moment verify_grad is not defined on complex gradient, and anyway not all Op accepts complex inputs.

So the current issue can serve two purposes:

  • register interests in having complex gradients (and complex Op)
  • deciding which complex gradient convention to follow
@educhesne
Copy link
Contributor Author

I've open a draft PR #1367 proposing an implementation of verify_grad following the JAX-like convention.
This is just to support the discussion; switching convention is simply removing the conjugate here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant