Skip to content

Extend verify_grad to complex gradient #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

educhesne
Copy link
Contributor

@educhesne educhesne commented Apr 14, 2025

Description

Extend verify_grad to complex gradient following the holomorphic gradient convention (as in JAX).
The decision on which convention to follow (JAX-like or torch-like) has not been taken yet; see issue #1366.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pytensor--1367.org.readthedocs.build/en/1367/

Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.05%. Comparing base (f1514eb) to head (806fad1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pytensor/gradient.py 80.00% 1 Missing and 3 partials ⚠️

❌ Your patch check has failed because the patch coverage (80.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1367   +/-   ##
=======================================
  Coverage   82.05%   82.05%           
=======================================
  Files         203      203           
  Lines       48863    48875   +12     
  Branches     8695     8696    +1     
=======================================
+ Hits        40093    40103   +10     
- Misses       6619     6620    +1     
- Partials     2151     2152    +1     
Files with missing lines Coverage Δ
pytensor/gradient.py 78.62% <80.00%> (+0.07%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant