Do not introduce 0 strides for broadcastable dimensions in DimShuffle #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some poorly implemented BLAS operations don't handle them correctly
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1267 +/- ##
=======================================
Coverage 81.99% 81.99%
=======================================
Files 188 188
Lines 48608 48608
Branches 8688 8688
=======================================
Hits 39857 39857
Misses 6586 6586
Partials 2165 2165 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our changes in #1226 led to failures in the PyMC test suited due to our BLAS implementation (at least GEMV) not handling 0 strides well: #1262
The value of the strides for length-1 dimensions is actually arbitrary. In that PR I set it to zero, in this one I set it to itemsize of the array. 1 would be odd? and I don't want to do a silly second loop to give the same sort of strides that
np.expand_dimsorreshapedo.📚 Documentation preview 📚: https://pytensor--1267.org.readthedocs.build/en/1267/