Fix get_vector_length incorrectly returning for shared variable without static shape

[Abhinav-Khot]

Description

Fixed get_vector_length returning a value when called with a shared variable which did not have static shape. This was done by removing a dispatch implemented in tensor/shared_var.py. After the changes, a ValueError is raised when a shared variable without static shape is passed.

Related Issue

• Closes get_vector_length incorrectly returns for shared variable without static shape #1239
• Related to #

Checklist

• Checked that the pre-commit linting/style checks pass
• Included tests that prove the fix is effective or that the new feature works
• Added necessary documentation (docstrings and/or example notebooks)
• If you are a pro: each commit corresponds to a relevant logical change

Type of change

• New feature / enhancement
• Bug fix
• Documentation
• Maintenance
• Other (please specify):

---

📚 Documentation preview 📚: https://pytensor--1295.org.readthedocs.build/en/1295/

[Abhinav-Khot]

There seem to be some tests that ensure the earlier behavior, should we deprecate them?

[ricardoV94]

There seem to be some tests that ensure the earlier behavior, should we deprecate them?

Keep them but use shared variables with static shape so they still work

Do add a new explicit test that it works with static shape and fails without, separately, unless one of the modified tests is basically that

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.00%. Comparing base (2a7f3e1) to head (13da552).
Report is 41 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1295   +/-   ##
=======================================
  Coverage   81.99%   82.00%           
=======================================
  Files         188      188           
  Lines       48553    48474   -79     
  Branches     8673     8665    -8     
=======================================
- Hits        39812    39751   -61     
+ Misses       6579     6575    -4     
+ Partials     2162     2148   -14     

Files with missing lines	Coverage Δ
pytensor/tensor/sharedvar.py	90.47% <ø> (-0.83%)	⬇️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Abhinav-Khot]

There seem to be some tests that ensure the earlier behavior, should we deprecate them?

Keep them but use shared variables with static shape so they still work

Do add a new explicit test that it works with static shape and fails without, separately, unless one of the modified tests is basically that

I have added this, could you please review?

[ricardoV94]

Thanks @Abhinav-Khot