Don't run the PyPi job all the time #1363
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| outputs: | ||
| should_run: ${{ steps.filter.outputs.any_changed }} | ||
| steps: | ||
| - uses: actions/checkout@v4 |
Check warning
Code scanning / zizmor
does not set persist-credentials: false Warning
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1363 +/- ##
=======================================
Coverage 82.05% 82.05%
=======================================
Files 203 203
Lines 48863 48863
Branches 8695 8695
=======================================
Hits 40093 40093
Misses 6619 6619
Partials 2151 2151 🚀 New features to boost your workflow:
|
maresb
reviewed
Apr 9, 2025
| # Run if it's a release, auto-release branch, or if relevant files changed on main | ||
| if: | | ||
| github.event_name == 'release' || | ||
| github.ref == 'refs/heads/auto-release' || |
There was a problem hiding this comment.
I believe we should delete all references to auto-release AFAIK it predates PyTensor
| outputs: | ||
| should_run: ${{ steps.filter.outputs.any_changed }} | ||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
Suggested change
| - uses: actions/checkout@v4 | |
| - uses: actions/checkout@v4 | |
| with: | |
| persist-credentials: false |
| @@ -17,9 +17,34 @@ concurrency: | |||
| cancel-in-progress: true | |||
|
|
|||
| jobs: | |||
There was a problem hiding this comment.
Make zizmor happy about default permissions
Suggested change
| jobs: | |
| permissions: {} | |
| jobs: |
lucianopaz
reviewed
Apr 14, 2025
| should_run: ${{ steps.filter.outputs.any_changed }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: dorny/paths-filter@v2 |
There was a problem hiding this comment.
Suggested change
| - uses: dorny/paths-filter@v2 | |
| - uses: dorny/paths-filter@v3 |
Comment on lines
+46
to
+47
| (github.ref == 'refs/heads/main' && needs.check_changes.outputs.should_run == 'true') || | ||
| (github.event_name == 'pull_request' && needs.check_changes.outputs.should_run == 'true') |
There was a problem hiding this comment.
Suggested change
| (github.ref == 'refs/heads/main' && needs.check_changes.outputs.should_run == 'true') || | |
| (github.event_name == 'pull_request' && needs.check_changes.outputs.should_run == 'true') | |
| ( | |
| (github.ref == 'refs/heads/main' || github.event_name == 'pull_request') | |
| && needs.check_changes.outputs.should_run == 'true' | |
| ) |
Comment on lines
+82
to
+83
| (github.ref == 'refs/heads/main' && needs.check_changes.outputs.should_run == 'true') || | ||
| (github.event_name == 'pull_request' && needs.check_changes.outputs.should_run == 'true') |
There was a problem hiding this comment.
Suggested change
| (github.ref == 'refs/heads/main' && needs.check_changes.outputs.should_run == 'true') || | |
| (github.event_name == 'pull_request' && needs.check_changes.outputs.should_run == 'true') | |
| ( | |
| (github.ref == 'refs/heads/main' || github.event_name == 'pull_request') | |
| && needs.check_changes.outputs.should_run == 'true' | |
| ) |
Comment on lines
+102
to
+103
| (github.ref == 'refs/heads/main' && needs.check_changes.outputs.should_run == 'true') || | ||
| (github.event_name == 'pull_request' && needs.check_changes.outputs.should_run == 'true') |
There was a problem hiding this comment.
Suggested change
| (github.ref == 'refs/heads/main' && needs.check_changes.outputs.should_run == 'true') || | |
| (github.event_name == 'pull_request' && needs.check_changes.outputs.should_run == 'true') | |
| ( | |
| (github.ref == 'refs/heads/main' || github.event_name == 'pull_request') | |
| && needs.check_changes.outputs.should_run == 'true' | |
| ) |
Comment on lines
+143
to
+144
| (github.ref == 'refs/heads/main' && needs.check_changes.outputs.should_run == 'true') || | ||
| (github.event_name == 'pull_request' && needs.check_changes.outputs.should_run == 'true') |
There was a problem hiding this comment.
Suggested change
| (github.ref == 'refs/heads/main' && needs.check_changes.outputs.should_run == 'true') || | |
| (github.event_name == 'pull_request' && needs.check_changes.outputs.should_run == 'true') | |
| ( | |
| (github.ref == 'refs/heads/main' || github.event_name == 'pull_request') | |
| && needs.check_changes.outputs.should_run == 'true' | |
| ) |
Comment on lines
+186
to
+187
| (github.ref == 'refs/heads/main' && needs.check_changes.outputs.should_run == 'true') || | ||
| (github.event_name == 'pull_request' && needs.check_changes.outputs.should_run == 'true') |
There was a problem hiding this comment.
Suggested change
| (github.ref == 'refs/heads/main' && needs.check_changes.outputs.should_run == 'true') || | |
| (github.event_name == 'pull_request' && needs.check_changes.outputs.should_run == 'true') | |
| ( | |
| (github.ref == 'refs/heads/main' || github.event_name == 'pull_request') | |
| && needs.check_changes.outputs.should_run == 'true' | |
| ) |
| check_changes: | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| should_run: ${{ steps.filter.outputs.any_changed }} |
There was a problem hiding this comment.
Suggested change
| should_run: ${{ steps.filter.outputs.any_changed }} | |
| should_run: | | |
| echo "${{ github.event_name == 'release' || | |
| github.ref == 'refs/heads/auto-release' || | |
| ( | |
| github.ref == 'refs/heads/main' || github.event_name == 'pull_request') && | |
| steps.filter.outputs.any_changed == 'true' | |
| ) }}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was mostly Claude-generated changes, so appreciate careful review.
Trying to save tons of compute time we wast building the cython-scan extension on the ubuntu wheel for every PR and push to main. Closes #219
📚 Documentation preview 📚: https://pytensor--1363.org.readthedocs.build/en/1363/