Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor edits to contributing documentation #930

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Minor edits to contributing documentation #930

wants to merge 3 commits into from

Conversation

HangenYuu
Copy link
Contributor

@HangenYuu HangenYuu commented Jul 15, 2024 •
edited
Loading

Description

Add minor edits to documentation in the contributing section.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

ricardoV94
ricardoV94 reviewed Jul 17, 2024
View reviewed changes
doc/extending/creating_a_numba_jax_op.rst Outdated
cannot be translated to JAX, since it involved a function with dynamic shapes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old non-example is still better. The new test is not even testing jax because the eye operations is constant folded before we call jax and jax never sees an eye

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make it a Note session about JAX unable to process graph with dynamic shape.

Copy link
Member

@ricardoV94 ricardoV94 Jul 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also note it's not that all dynamic shapes are disallowed. They can for instance depend on input shapes, so eye(x.shape[0]) would probably work (or easily be made to work) even if x has a dynamic shape

Copy link
Contributor Author

@HangenYuu HangenYuu Jul 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardoV94 I included that.

@fonnesbeck
Copy link
Member

Is this still active?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twiecki twiecki twiecki left review comments

@ricardoV94 ricardoV94 ricardoV94 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HangenYuu @fonnesbeck @twiecki @ricardoV94